Add WPT for Selection.modify() character movement in bidi text#59879
Merged
Conversation
Tests to support the spec change PR - w3c/selection-api#357 Bug: 499819853 Change-Id: Ia827a90b9c12f64d04ea72cb2bee8f0535bedd6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7848414 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Pranav Modi <pranavmodi@microsoft.com> Commit-Queue: Sambamurthy Bandaru <sambamurthy.bandaru@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1631971}
3a0001a to
1e6ee37
Compare
wpt-pr-bot
approved these changes
May 18, 2026
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests to support the spec change PR -
w3c/selection-api#357
Bug: 499819853
Change-Id: Ia827a90b9c12f64d04ea72cb2bee8f0535bedd6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7848414
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Pranav Modi <pranavmodi@microsoft.com>
Commit-Queue: Sambamurthy Bandaru <sambamurthy.bandaru@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1631971}